Zed nightly: fs: Make `OsWatcher` own a `BackgroundExecutor` (#65700)
Zed · IDE / editor · Released
View official release notes ↗ Copy link
Summary
While looking into something else with the extension CLI, I noticed that
sometimes the CLI would not shut down after compilation.
GPTs analysis was the following:
A macOS process sample showed this sequence:
- main finishes writing archive.tar.gz and manifest.json.
- Dropping RealFs drops its fields in declaration order.
- Dropping a watcher’s channel wakes its dispatch task, but the
scheduler is already gone. - That wake synchronously drops the task’s channel receiver while the
event-listener notification lock is held, deadlocking.
Thus, fixing this here by having the watcher own an executor which
prevents this from happening. Not the best fix, but better than having
this around.
Testing
Manually tested as well as with a test below.
Self-review
- I've reviewed my diff for quality, security, reliability, and
performance. - [-] UI changes follow the
checklist. - Tests cover the new or changed behavior.
Release Notes:
- N/A
Source: Zed's official Zed release notes at github.com. Text reproduced from the source for reference; all rights belong to Zed. Patchwire is not affiliated with Zed.
More Zed releases
- v1.24.3 · Oct 16, 2026
- collab-staging: agent_ui: Respect effort-specific thinking controls (#62480) · Oct 16, 2026
- v1.25.0-pre · Oct 14, 2026
- v1.24.2 · Oct 14, 2026
- collab-staging: anthropic: Add support for Sonnet and Haiku 5.5 (#65555) · Oct 13, 2026
- nightly: Fix cpal-related issue on Windows (#65550) · Oct 13, 2026
- v1.24.2-pre · Oct 12, 2026
- v1.23.3 · Oct 12, 2026